Update formats.rst #7129
Closed
Update formats.rst #7129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller is a little bit confusing. I think it should be a showAction, since it's name is article_show and it gets an id as parameter.
|
The complete article is very inconsistent. At the beginning it is talking about |
Closed
|
You're right. I will fix those parts as well:) |
|
Hi @berbadger! Thanks for starting this great PR, this article is indeed pretty inconsistent. I've taken your commits and added two of my own in order to make the article 100% consistent and to add a small tip: #7800 You're commits are kept in that PR, so you still get all credits you deserve. Thanks for helping us and I hope to see you back! :) |
xabbuh
added a commit
that referenced
this pull request
May 12, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Improved the Templating formats article This continues (and replaces) #7129 . It also adds a minor tip about FOSRestBundle's format listener, as I think it's a quite usefull tool when talking about request formats. Commits ------- dfe9d11 Mentioned FOSRestBundle's content negotiation 90924db Used the article example consistently in the example 5862c75 Update formats.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller is a little bit confusing. I think it should be a showAction, since it's name is article_show and it gets an id as parameter.