Skip to content

adding the namespace for ArrayInput #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

adding the namespace for ArrayInput #7192

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2518cf6
adding the namespace for ArrayInput
nodefortytwo Nov 28, 2016
f8633b2
Added missing semicolon.
nodefortytwo Nov 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions console/calling_commands.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ generating Doctrine2 proxies, dumping Assetic assets, ...).

Calling a command from another one is straightforward::

use Symfony\Component\Console\Input\ArrayInput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon

// ...

protected function execute(InputInterface $input, OutputInterface $output)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do it for ArrayInput, shouldn't we do it for these too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't because they are standard to all commands, I included ArrayInput as its the first time (in my experience) the concept is introduced.

{
$command = $this->getApplication()->find('demo:greet');
Expand Down