Improved the image for Doctrine + Web Debug Toolbar #7306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiereguiluz Does that mean it's worthless (or could even hurt us) when using subdirectories inside the |
|
@xabbuh I'm afraid so :( |
|
In this case, I suggest that we do not use subdirectories at all which would allow us to detect conflicts ourselves earlier. What do you think? |
|
I'd recommend to finish this PR first and then we can discuss about the best strategy for the naming of images. Thanks! |
|
Please, let's merge this to fix the image problem. Thanks! |
|
Thank you @javiereguiluz. |
xabbuh
added a commit
that referenced
this pull request
Mar 3, 2017
…ereguiluz) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7306). Discussion ---------- Improved the image for Doctrine + Web Debug Toolbar This fixes #7301. The image file renaming is recommended because all images from the Symfony Docs are flattened in a single `_images/` directory. We should start "namespacing" image file names to avoid collisions. ### Before  ### After  Commits ------- a01e522 Improved the image for Doctrine + Web Debug Toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7301. The image file renaming is recommended because all images from the Symfony Docs are flattened in a single
_images/directory. We should start "namespacing" image file names to avoid collisions.Before
After