Skip to content

Mentioned that validator can validate DateTimeInterface too #7405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #7333.

or a string (or an object that can be cast into a string) that follows
a valid "HH:MM:SS" format.
Validates that a value is a valid time, meaning either a ``DateTime`` object or
an object implementing ``DateTimeInterface`` or a string (or an object that can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be shortened a bit as the DateTime class implements DateTimeInterface too:

[...] meaning an object implementing DateTimeInterface or a string [...]

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh
Copy link
Member

xabbuh commented Jan 31, 2017

Thank you Javier.

@xabbuh xabbuh closed this Jan 31, 2017
xabbuh added a commit that referenced this pull request Jan 31, 2017
… too (javiereguiluz)

This PR was squashed before being merged into the master branch (closes #7405).

Discussion
----------

Mentioned that validator can validate DateTimeInterface too

This fixes #7333.

Commits
-------

3a15a21 Mentioned that validator can validate DateTimeInterface too
@javiereguiluz javiereguiluz deleted the fix_7333 branch May 24, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator now supports DateTimeInterface instances for times
3 participants