Skip to content

Update guard_authentication.rst #7431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update guard_authentication.rst #7431

wants to merge 3 commits into from

Conversation

alcohol
Copy link
Contributor

@alcohol alcohol commented Jan 31, 2017

I still feel like the answer to "Can I have Multiple Authenticators?" is a bit confusing even with these adjustments, but I think it makes it more clear now at least what you have to adjust configuration wise. The original example simply shows the configuration for a single guard which is rather confusing considering the question it attempts to answer.

BTW; can someone else add or give me the XML change necessary? I never use XML configuration so I am not sure if it is supposed to be an attribute or another element or what not.

I still feel like the answer to "Can I have Multiple Authenticators?" is a bit confusing even with these adjustments, but I think it makes it more clear now at least what you have to adjust configuration wise. The original example simply shows the configuration for a single guard which is rather confusing considering the question it attempts to answer.

BTW; can someone else add or give me the XML change necessary? I never use XML configuration so I am not sure if it is supposed to be an attribute or another element or what not.
@@ -531,6 +533,7 @@ Frequently Asked Questions

<guard>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the entry point, you can use an attribute here:

<guard entry-point="app.form_login_authenticator">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

add guard attribute
copy & paste is difficult...
@xabbuh
Copy link
Member

xabbuh commented Jan 31, 2017

👍

Status: Reviewed

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh
Copy link
Member

xabbuh commented Jan 31, 2017

Thank you @alcohol.

xabbuh added a commit that referenced this pull request Jan 31, 2017
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #7431).

Discussion
----------

Update guard_authentication.rst

I still feel like the answer to "Can I have Multiple Authenticators?" is a bit confusing even with these adjustments, but I think it makes it more clear now at least what you have to adjust configuration wise. The original example simply shows the configuration for a single guard which is rather confusing considering the question it attempts to answer.

BTW; can someone else add or give me the XML change necessary? I never use XML configuration so I am not sure if it is supposed to be an attribute or another element or what not.

Commits
-------

510ee61 Update guard_authentication.rst
@xabbuh xabbuh closed this Jan 31, 2017
@alcohol alcohol deleted the patch-1 branch February 1, 2017 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants