Skip to content

[SwiftMailer] Update future reference #7510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions reference/configuration/swiftmailer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ url

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version added? (same for other options below)

**type**: ``string``

.. versionadded:: 2.4.2
The ``url`` option was added in SwiftMailerBundle 2.4.2.

The entire SwiftMailer configuration using a DSN-like URL format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"using" => "uses"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "using" is correct here. We're not saying that Swift "uses" this ... but that the "url" option is all the Swift config using a DSN format.


Example: ``smtp://user:pass@host:port/?timeout=60&encryption=ssl&auth_mode=login&...``
Expand Down Expand Up @@ -97,20 +100,29 @@ timeout

**type**: ``integer``

.. versionadded:: 2.4.2
The ``url`` option was added in SwiftMailerBundle 2.4.2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter looks wrong here and below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭 it's fixed now!


The timeout in seconds when using ``smtp`` as the transport.

source_ip
~~~~~~~~~

**type**: ``string``

.. versionadded:: 2.4.2
The ``url`` option was added in SwiftMailerBundle 2.4.2.

The source IP address when using ``smtp`` as the transport.

local_domain
~~~~~~~~~~~~

**type**: ``string``

.. versionadded:: 2.4.2
The ``url`` option was added in SwiftMailerBundle 2.4.2.

The domain name to use in ``HELO`` command.

encryption
Expand Down