Skip to content

[Yaml] fix dump arguments #7518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2017
Merged

[Yaml] fix dump arguments #7518

merged 1 commit into from
Feb 28, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 21, 2017

No description provided.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand this change ... and to be honest, the entire "Handling Invalid Types" section looks confusing to me.

@xabbuh
Copy link
Member Author

xabbuh commented Feb 22, 2017

The example was wrong as we passed the flags as the second argument to dump while they in fact have to be the fourth argument. The added arguments are just the default values of the $inline and $indent parameters.

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 OK then. Thanks!

@xabbuh xabbuh merged commit 852c0c0 into symfony:3.2 Feb 28, 2017
xabbuh added a commit that referenced this pull request Feb 28, 2017
This PR was merged into the 3.2 branch.

Discussion
----------

[Yaml] fix dump arguments

Commits
-------

852c0c0 [Yaml] fix dump arguments
@xabbuh xabbuh deleted the issue-7516 branch February 28, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants