Update without_class.rst #7552
Closed
Update without_class.rst #7552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A right bracket is missing
xabbuh
reviewed
Mar 1, 2017
form/without_class.rst
Outdated
| @@ -105,4 +105,4 @@ but here's a short example: | |||
|
|
|||
| .. code-block:: php | |||
|
|
|||
| new NotBlank(array('groups' => array('create', 'update')) | |||
| new NotBlank(array('groups' => array('create', 'update'))) | |||
There was a problem hiding this comment.
Shouldn't the code block be part of the tip? I suggest to indent everything starting with line 106 by additional four spaces.
|
@xabbuh : like that ? |
HeahDude
reviewed
Mar 1, 2017
form/without_class.rst
Outdated
| .. code-block:: php | ||
|
|
||
| new NotBlank(array('groups' => array('create', 'update'))) | ||
| new NotBlank(array('groups' => array('create', 'update'))) |
There was a problem hiding this comment.
You can remove the .. code-block:: notation but you then need to use the default php one by adding a double colon :: at the end of the line 104.
There was a problem hiding this comment.
(for another language the notation should have been kept and indented as well)
|
Thank you @Benjamin-Porquet. |
xabbuh
added a commit
that referenced
this pull request
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A right bracket is missing