[Form] Fixed by_reference option with explicit cloning #7569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
changed the title
HeahDude
force-pushed
the
fix/form-inherit_data
branch
from
97f073f to
2186307
Compare
wouterj
reviewed
Mar 5, 2017
| @@ -31,7 +31,7 @@ Notice that ``setAuthor()`` is not called. The author is modified by reference. | |||
| If you set ``by_reference`` to false, submitting looks like this:: | |||
|
|
|||
| $article->setTitle('...'); | |||
| $author = $article->getAuthor(); | |||
| $author = (clone) $article->getAuthor(); | |||
There was a problem hiding this comment.
Very minor, but clone isn't a type cast so please remove the () to avoid confusion.
There was a problem hiding this comment.
Of course, fixed, thanks!
|
👍 |
HeahDude
force-pushed
the
fix/form-inherit_data
branch
from
2186307 to
195ed65
Compare
|
Thank you @HeahDude. |
xabbuh
added a commit
that referenced
this pull request
Mar 7, 2017
…eahDude) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fixed by_reference option with explicit cloning Commits ------- 195ed65 [Form] Fixed by_reference option with explicit cloning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.