Add docs to register custom form extensions and types for unit testing #7578

pierredup · 2017-03-06T11:33:36Z

Docs for symfony/symfony#21780 to register custom extensions and types

atailouloute · 2017-03-06T11:43:14Z

form/unit_testing.rst

+If your forms uses the ``invalid_message`` or ``constraints`` option for validation, you need to
+register the validation extension which provides this options.
+Luckily Symfony provides a custom test class which does this for you.
+In order to have this option registered, your test needs to extend from the


to extend the .. class would be better, no ? (Without from)

OskarStark · 2017-03-06T14:26:04Z

form/unit_testing.rst

@@ -156,12 +156,31 @@ make sure the ``FormRegistry`` uses the created instance::
        }
    }

+Forms Using Validation
+------------------------------------


please keep the underline as long as the title

xabbuh · 2017-03-06T15:53:35Z

form/unit_testing.rst

            );
        }

        // ... your tests
    }

+It is also possible to load custom form types, form type extensions or type guessers using the
+``getTypedExtensions``, ``getTypes`` and ``getTypeGuessers`` methods.


This should be part of a separate pull request as we will have to merge it into the master branch (the rest can be merged into the docs for Symfony 2.7).

One thing I forgot: Can you also add a versionadded directive that mentions the introduction of the new methods?

…ons during unit testing (pierredup) This PR was squashed before being merged into the 3.3-dev branch (closes #21780). Discussion ---------- [DX] [Form] Add helper method to register form extensions during unit testing | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#7578 Add helper method to register form extensions during unit testing, so it's easier to register custom form type extensions, form types, or type guessers Commits ------- bab562a [DX] [Form] Add helper method to register form extensions during unit testing

…ons during unit testing (pierredup) This PR was squashed before being merged into the 3.3-dev branch (closes #21780). Discussion ---------- [DX] [Form] Add helper method to register form extensions during unit testing | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#7578 Add helper method to register form extensions during unit testing, so it's easier to register custom form type extensions, form types, or type guessers Commits ------- bab562a987 [DX] [Form] Add helper method to register form extensions during unit testing

HeahDude

Thanks for that PR! Can you please separate the changes as @xabbuh asked?

HeahDude · 2017-03-06T21:35:25Z

form/unit_testing.rst

+Forms Using Validation
+----------------------
+
+If your forms uses the ``invalid_message`` or ``constraints`` option for validation, you need to


It should either be If your form uses or If your forms use.

HeahDude · 2017-03-06T21:36:29Z

form/unit_testing.rst

+----------------------
+
+If your forms uses the ``invalid_message`` or ``constraints`` option for validation, you need to
+register the validation extension which provides this options.


this => these

HeahDude · 2017-03-06T21:36:50Z

form/unit_testing.rst

+
+If your forms uses the ``invalid_message`` or ``constraints`` option for validation, you need to
+register the validation extension which provides this options.
+Luckily Symfony provides a custom test class which does this for you.


I would suggest Luckily Symfony provides a base test class which takes care of it, just extend [class].

And get rid of the following sentence, what do you think?

HeahDude · 2017-03-06T21:40:32Z

form/unit_testing.rst

+:class:`Symfony\\Component\\Form\\Tests\\Extension\\Validator\\Type\\TypeTestCase`
+class::
+
+    // tests/AppBundle/Form/Type/TestedTypeTests.php


Please remove the last s in TestedTypeTest.php.

pierredup · 2017-03-07T10:06:33Z

I created a separate PR for 2.7 #7587.

When that is merged, it should squash this diff to only leave the sentence for the new methods added symfony/symfony#21780 (I'll just resolve any conflicts there might be after that PR is merged)

pierredup · 2017-03-08T08:25:45Z

I removed the validator extension part in this docs, so it's not dependent on other changes, and can be merged to document the new methods added

HeahDude · 2017-03-10T06:47:16Z

form/unit_testing.rst

@@ -199,6 +199,9 @@ allows you to return a list of extensions to register::
 It is also possible to load custom form types, form type extensions or type guessers using the
 ``getTypedExtensions``, ``getTypes`` and ``getTypeGuessers`` methods.

+.. versionadded:: 3.3
+    The ``getTypedExtensions``, ``getTypes`` and ``getTypeGuessers`` was introduced in Symfony 3.3.


"The [...] methods were introduced [...]."

HeahDude

👍

xabbuh · 2017-04-15T12:59:04Z

Thank you @pierredup. FYI, I have taken the proposed changes from symfony/symfony#22445 taken into account in 68bcaa0.

carsonbot added the Status: Needs Review label Mar 6, 2017

pierredup mentioned this pull request Mar 6, 2017

[DX] [Form] Add helper method to register form extensions during unit testing symfony/symfony#21780

Closed

atailouloute reviewed Mar 6, 2017

View reviewed changes

OskarStark requested changes Mar 6, 2017

View reviewed changes

xabbuh reviewed Mar 6, 2017

View reviewed changes

HeahDude reviewed Mar 6, 2017

View reviewed changes

Add note about new methods to add extensions for forms testing

c53245d

pierredup force-pushed the forms-testing branch from 295bcf4 to c53245d Compare March 8, 2017 08:24

pierredup changed the title ~~Add docs about the validator TypeTestCase class~~ Add docs to register custom form extensions and types for unit testing Mar 8, 2017

Added verionadded to forms doc

fdc288a

HeahDude reviewed Mar 10, 2017

View reviewed changes

HeahDude added the Form label Mar 10, 2017

Changed was to were

7bf937c

roman-1983 approved these changes Mar 15, 2017

View reviewed changes

OskarStark approved these changes Mar 15, 2017

View reviewed changes

HeahDude approved these changes Mar 26, 2017

View reviewed changes

HeahDude added Status: Reviewed and removed Status: Needs Review labels Mar 26, 2017

xabbuh closed this in 8421e72 Apr 15, 2017

xabbuh added a commit that referenced this pull request Apr 15, 2017

[#7578] minor tweaks

68bcaa0

javiereguiluz mentioned this pull request May 28, 2018

[Form] Missing note about validation and form type tests #7566

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add docs to register custom form extensions and types for unit testing #7578

Add docs to register custom form extensions and types for unit testing #7578

Uh oh!

pierredup commented Mar 6, 2017 •

edited

Loading

Uh oh!

atailouloute Mar 6, 2017

Uh oh!

OskarStark Mar 6, 2017

Uh oh!

xabbuh Mar 6, 2017

Uh oh!

xabbuh Mar 8, 2017

Uh oh!

HeahDude left a comment

Uh oh!

HeahDude Mar 6, 2017

Uh oh!

HeahDude Mar 6, 2017

Uh oh!

HeahDude Mar 6, 2017

Uh oh!

HeahDude Mar 6, 2017

Uh oh!

pierredup commented Mar 7, 2017 •

edited

Loading

Uh oh!

pierredup commented Mar 8, 2017

Uh oh!

HeahDude Mar 10, 2017

Uh oh!

HeahDude left a comment

Uh oh!

xabbuh commented Apr 15, 2017

Uh oh!

Uh oh!

Uh oh!

Add docs to register custom form extensions and types for unit testing #7578

Add docs to register custom form extensions and types for unit testing #7578

Uh oh!

Conversation

pierredup commented Mar 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeahDude left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierredup commented Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierredup commented Mar 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeahDude left a comment

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Apr 15, 2017

Uh oh!

Uh oh!

pierredup commented Mar 6, 2017 •

edited

Loading

pierredup commented Mar 7, 2017 •

edited

Loading