Skip to content

Fix build documentation for Windows environments #7590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Mar 7, 2017

Fix #7548 Now there should be no differences between environments when we build the documentation locally.

Copy link
Member Author

@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workaround from Makefile

@@ -5,8 +5,8 @@ REM Command file for Sphinx documentation
if "%SPHINXBUILD%" == "" (
set SPHINXBUILD=sphinx-build
)
set BUILDDIR=_build
set ALLSPHINXOPTS=-d %BUILDDIR%/doctrees %SPHINXOPTS% .
set BUILDDIR=.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set BUILDDIR=_build
set ALLSPHINXOPTS=-d %BUILDDIR%/doctrees %SPHINXOPTS% .
set BUILDDIR=.
set ALLSPHINXOPTS=-c %BUILDDIR% -d %BUILDDIR%/doctrees %SPHINXOPTS% ..
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snoek09
Copy link

snoek09 commented Mar 7, 2017

Status: reviewed.

Thanks @yceruto for checking and fixing this for Windows users 👍
Also related to #7216.

@xabbuh
Copy link
Member

xabbuh commented Mar 7, 2017

Thank you @yceruto.

@xabbuh xabbuh merged commit 05412be into symfony:2.7 Mar 7, 2017
xabbuh added a commit that referenced this pull request Mar 7, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Fix build documentation for Windows environments

Fix #7548 Now there should be no differences between environments when we build the documentation locally.

Commits
-------

05412be Fix doc build in Windows environments
@yceruto yceruto deleted the fix_7548 branch March 7, 2017 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants