Skip to content

Update bundles directory structure #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

tabbi89
Copy link
Contributor

@tabbi89 tabbi89 commented Mar 7, 2017

In directory structure we have

Resources/views/
Holds templates organized by controller name (e.g. Hello/index.html.twig).

In my opinion it would be more consistent to connect this controller name also in the first element in list "Controller".

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wouterj
Copy link
Member

wouterj commented Mar 7, 2017

👍 Thanks!

(I would maybe prefer to do it the other way around: Keep RandomController and use Random/digit.html.twig as template. But we can do this during the merge)

@xabbuh
Copy link
Member

xabbuh commented Mar 13, 2017

Thank you @tabbi89.

@xabbuh xabbuh merged commit 1092626 into symfony:2.7 Mar 13, 2017
xabbuh added a commit that referenced this pull request Mar 13, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Update bundles directory structure

In directory structure we have

```
Resources/views/
Holds templates organized by controller name (e.g. Hello/index.html.twig).
```

In my opinion it would be more consistent to connect this controller name also in the first element in list "Controller".

Commits
-------

1092626 Update bundles directory structure
xabbuh added a commit that referenced this pull request Mar 13, 2017
xabbuh added a commit that referenced this pull request Mar 13, 2017
* 2.7: (30 commits)
  [#7560] remove unused use statements
  Resolving $this usage outside a class on form.rst
  Fix some odd English in the PDOSessionHandler docs
  Fix typo
  Add the description for the HTTP status because it's not that common
  Update exception code status
  [#7592] some minor tweaks
  Fix link for Twig Extensions documentation
  Update framework.rst [Fix esi tag]
  Update render_without_controller.rst
  Update matchers.rst
  Update matchers.rst
  Update locale_sticky_session.rst
  Update framework.rst
  Update import.rst
  Update load_balancer_reverse_proxy.rst
  Moved the requirements file
  [#7509] add missing references
  Added a mention to APCu Polyfill in the performance article
  [#7497] minor rewording
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants