Updating doctrine class use #7750
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because now composer.json of symfony 3.2 use doctrine ^2.5 shouldn't we use use Doctrine\Common\Persistence\Event\LifecycleEventArgs; by default in exemple ?
It's seems that getEntity() is deprecated and getEntityManager() doesn't exist anymore, now doctrine use Object as term.
| @@ -169,8 +169,8 @@ interface and have an event method for each event it subscribes to:: | |||
| namespace AppBundle\EventListener; | |||
|
|
|||
| use Doctrine\Common\EventSubscriber; | |||
| use Doctrine\ORM\Event\LifecycleEventArgs; | |||
| // for Doctrine 2.4: Doctrine\Common\Persistence\Event\LifecycleEventArgs; | |||
| // for Doctrine < 2.4: use Doctrine\ORM\Event\LifecycleEventArgs; | |||
There was a problem hiding this comment.
We can't replace "Doctrine 2.4" by "Doctrine < 2.4". It should be "Doctrine <= 2.4" or "Doctrine < 2.5", right?
There was a problem hiding this comment.
The use Doctrine\ORM\Event\LifecycleEventArgs; need to be use for doctrine before 2.4.
For doctrine >= 2.4 we need to use Doctrine\Common\Persistence\Event\LifecycleEventArgs;
javiereguiluz
approved these changes
Jul 6, 2017
|
Thank you @David-Crty. |
xabbuh
added a commit
that referenced
this pull request
Jul 7, 2017
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7750). Discussion ---------- Updating doctrine class use Because now composer.json of symfony 3.2 use doctrine ^2.5 shouldn't we use use Doctrine\Common\Persistence\Event\LifecycleEventArgs; by default in exemple ? Commits ------- 958df16 Updating doctrine class use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because now composer.json of symfony 3.2 use doctrine ^2.5 shouldn't we use use Doctrine\Common\Persistence\Event\LifecycleEventArgs; by default in exemple ?