[HttpFoundation] Fix clearstatcache first arg #7890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
May 10, 2017
xabbuh
approved these changes
May 10, 2017
|
Good catch, thanks @ogizanagi. |
xabbuh
added a commit
that referenced
this pull request
May 12, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] Fix clearstatcache first arg According to http://php.net/manual/en/function.clearstatcache.php: > **filename** Clear the realpath and the stat cache for a specific filename only; _only used if **clear_realpath_cache** is **TRUE**_. So it seems either we provide the second argument and set the first one to `true`, either the second arg is not used at all. Commits ------- 92cc724 [HttpFoundation] Fix clearstatcache first arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to http://php.net/manual/en/function.clearstatcache.php:
So it seems either we provide the second argument and set the first one to
true, either the second arg is not used at all.