Skip to content

Update database.rst #8001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Update database.rst #8001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/database.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ it's easy to pass a mock object within a test::

// Now, mock the repository so it returns the mock of the employee
$employeeRepository = $this
->getMockBuilder(EntityManagerInterface::class)
->getMockBuilder(EntityRepository::class)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should not mock the ObjectRepository interface instead. We then would even not have to use the disableOriginalConstructor() call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always prefer to makes those kind of changes simultaneously for all existing articles, to avoid differences between articles. Maybe we can open an issue to not forget about that. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #8144

->disableOriginalConstructor()
->getMock();
$employeeRepository->expects($this->once())
Expand Down