Skip to content

Added the command to install babel-preset for babel-loader #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2017
Merged

Added the command to install babel-preset for babel-loader #8058

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e74e556
Added the command to install babel-preset for babel-loader
bogdaniel Jun 18, 2017
ab41baf
Update babel.rst
bogdaniel Jun 18, 2017
b9edef8
Minor reword
javiereguiluz Jul 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/encore/babel.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Configuring Babel

Need to extend the Babel configuration further? The easiest way is via
``configureBabel()``:
But first let's install the babel preset.

``yarn add babel-preset-es2017``
This will install the preset that we will use later to configure the babel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is indeed a good clarification! But what about adding this information as comments in the code block below (right above the es2017 line. We can say something like:

// make sure to install any presets you want to use
// yarn add ...


.. code-block:: javascript

Expand Down