Skip to content

Mention lazy loading for Doctrine event listeners #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Mention lazy loading for Doctrine event listeners #8080

wants to merge 3 commits into from

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jun 23, 2017

Would have saved me two hours if I had known about this feature before.

@mpdude
Mention lazy loading for event listeners
d48cd70 
Would have saved me two hours if I had known about this feature before.
@mpdude mpdude changed the title Mention lazy loading for event listeners Mention lazy loading for Doctrine event listeners Jun 23, 2017
fsevestre
fsevestre reviewed Jun 23, 2017
View reviewed changes
doctrine/event_listeners_subscribers.rst Outdated

.. note::

  Marking an event listener as ``lazy`` has nothing to do with lazy serivce
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo serivce -> service

HeahDude
HeahDude approved these changes Jul 29, 2017
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that PR!

doctrine/event_listeners_subscribers.rst Outdated

use AppBundle\EventListener\SearchIndexer;
use AppBundle\EventListener\SearchIndexer2;
use AppBundle\EventListener\SearchIndexerSubscriber;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's no need for those two last use statements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeahDude Removed

@HeahDude HeahDude added this to the 2.7 milestone Jul 29, 2017
@HeahDude HeahDude mentioned this pull request Jul 29, 2017
Closed
@xabbuh
Copy link
Member

xabbuh commented Aug 1, 2017

Thank you @mpdude.

xabbuh added a commit that referenced this pull request Aug 1, 2017
@xabbuh
minor #8080 Mention lazy loading for Doctrine event listeners (mpdude)
a64d407 
This PR was squashed before being merged into the 2.7 branch (closes #8080).

Discussion
----------

Mention lazy loading for Doctrine event listeners

Would have saved me two hours if I had known about this feature before.

Commits
-------

46c82d5 Mention lazy loading for Doctrine event listeners
@xabbuh xabbuh closed this Aug 1, 2017
@mpdude mpdude deleted the patch-1 branch August 1, 2017 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsevestre fsevestre fsevestre left review comments

@xabbuh xabbuh xabbuh approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Doctrine Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@mpdude @xabbuh @fsevestre @HeahDude @carsonbot