Skip to content

Fix Swift example code #8102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Swift example code #8102

wants to merge 1 commit into from

Conversation

ZeZiNhOo
Copy link

At least with Symfony 2.8, the example code fails. I have found this version works, but it probably needs review ;-)

@ZeZiNhOo
Fix Swift example code
f7cef34 
At least with Symfony 2.8, the example code fails. I have found this version works, but it probably needs review ;-)
@xabbuh
Copy link
Member

xabbuh commented Jul 1, 2017

Thank you for this pull request @ZeZiNhOo. However, the newInstance() factory method does not work with Swiftmailer 6 anymore. So this change will not fix the issue entirely. Luckily, we have another pending pull request (see #8068) which will fix this (and other similar occurrences). That's why I am going to close here. I hope to see you back soon with some other changes.

@xabbuh xabbuh closed this Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeZiNhOo @xabbuh @carsonbot