Skip to content

Add information for enable property_info service #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

Kleinast
Copy link
Contributor

@Kleinast Kleinast commented Jul 5, 2017

add code for enable property_info service because service is not available by default in symfony full stack.
Also, I don't really understand why the property_info is mentionned in ReflectionExtractor section because property_info service lead to Symfony\Component\PropertyInfo\PropertyInfoExtractor and not the ReflectionExtractor class.

add code for enable property_info service because service is not available by default in symfony full stack.
Also, I don't really understand why the property_info is mentionned in ReflectionExtractor section because property_info service lead to Symfony\Component\PropertyInfo\PropertyInfoExtractor and not the ReflectionExtractor class.
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to reword a bit your original changes because in the articles about components is always tricky to talk about the full Symfony framework (in theory we should never mention the full framework).

@xabbuh
Copy link
Member

xabbuh commented Jul 7, 2017

Thank you Bastien.

xabbuh added a commit that referenced this pull request Jul 7, 2017
…t, javiereguiluz)

This PR was submitted for the 3.3 branch but it was merged into the 2.8 branch instead (closes #8125).

Discussion
----------

Add information for enable property_info service

add code for enable property_info service because service is not available by default in symfony full stack.
Also, I don't really understand why the property_info is mentionned in ReflectionExtractor section because property_info service lead to Symfony\Component\PropertyInfo\PropertyInfoExtractor and not the ReflectionExtractor class.

Commits
-------

ffe0dc0 Reworded the tip about property_info and Symfony framework
77f6a6d remove useless space
01563dd Add information for enable property_info service
@xabbuh xabbuh closed this Jul 7, 2017
@Kleinast
Copy link
Contributor Author

Kleinast commented Jul 7, 2017

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants