Add pipe to dump command #8227
Closed
Add pipe to dump command #8227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save creating an interim file (and cluttering up the directory) by using pipe to create the image file immediately.
javiereguiluz
approved these changes
Jul 26, 2017
There was a problem hiding this comment.
To me it looks good ... but I've never dumped a workflow, so maybe I'm missing something.
In any case, @philwc thanks for your first contribution to Symfony Docs.
|
I don't think this needs to be documented this way. It may happen that you want to edit the dot file before transforming it. Having two steps here seems fine to me. |
|
I would have thought that was pretty rare for most use cases, but if you'd rather leave as is, that's fine. |
xabbuh
approved these changes
Jul 27, 2017
|
To me this looks good. It's IMO easy to figure out how to dump the file first if you need to manipulate it while it may not be obvious that you can pass the definition to be dumped to STDIN of the |
|
Fair enough then. |
|
Thank you @philwc. |
xabbuh
added a commit
that referenced
this pull request
Aug 1, 2017
This PR was submitted for the 3.3 branch but it was merged into the 3.2 branch instead (closes #8227). Discussion ---------- Add pipe to dump command Save creating an interim file (and cluttering up the directory) by using pipe to create the image file immediately. Commits ------- 8aa2fbb Add pipe to dump command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save creating an interim file (and cluttering up the directory) by using pipe to create the image file immediately.