Some typos #8230
Closed
Some typos #8230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Jul 26, 2017
service_container/3.3-di-changes.rst
Outdated
| @@ -433,7 +433,7 @@ In this case, you've created a class that implements ``EventSubscriberInterface` | |||
| and registered it as a service. This is more than enough for the container to know | |||
| that you want this to be used as an event subscriber: more configuration is not needed. | |||
| And the tags system is its own, Symfony-specific mechanism. And of course, you can | |||
| always default ``autoconfigure`` to false in ``services.yml``, or disable it for a specific | |||
| always set ``autoconfigure`` to ``false`` (=default) in ``services.yml``, or disable it for a specific | |||
There was a problem hiding this comment.
I'd remove the (=default) mention here because we already explain the default config before in this article.
There was a problem hiding this comment.
Yes this line changes should be reverted.
There was a problem hiding this comment.
Sure, see 5bc4c4e
There was a problem hiding this comment.
I would keep "default" instead of "set" since it's meant to be under _default key.
There was a problem hiding this comment.
"default" is not a verb you can use in this context.
As suggested by symfony#8230 (review)
xabbuh
approved these changes
Jul 27, 2017
|
Thank you @ThomasLandauer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.