Skip to content

Add a note about using Composer to install Encore #8385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 11, 2017

No description provided.


.. code-block:: terminal

$ composer require encore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code block needs to be indented by four spaces if it should be part of the tip.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, fixed

Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just another minor comment: Maybe we should move this tip right below the note above that mentions how to install Encore using npm.

@xabbuh xabbuh added this to the 3.3 milestone Sep 11, 2017
@fabpot
Copy link
Member Author

fabpot commented Sep 11, 2017

Make sense, moved the note.

@xabbuh
Copy link
Member

xabbuh commented Sep 12, 2017

Thank you @fabpot.

@xabbuh xabbuh merged commit 6844538 into symfony:3.3 Sep 12, 2017
xabbuh added a commit that referenced this pull request Sep 12, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

Add a note about using Composer to install Encore

Commits
-------

6844538 added a note about using Composer to install Encore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants