server_version is not available for slaves

[jdeniau]

No description provided.

[javiereguiluz]

Thanks for this fix and congrats on your first contribution to this repo!

I have a question: does setting this option throw an exception or is it ignored? If is it ignored, is it because of a Doctrine bug or is it because it's OK to not configure the server_version of slaves? (which at first it seems strange because if not setting this option to the master causes troubles, it should cause them too for the slaves).

[jdeniau]

@javiereguiluz it does throw the following exception :

 Unrecognized option "server_version" under "doctrine.dbal.connections.foo_master.slaves.foo_slave"

Apparently, it's more a bug in the DoctrineBundle implementation, because if you look in doctrine's MasterSlaveConnection, you can see a chooseConnectionConfiguration.

This methods seems to get the master or slave configuration, to do platform specific things, like converting from/to database, so the serverVersion seems to be "host-specific".

I can eventually help with this, but I do not really know DoctrineBundle internals, so maybe another person can be more at ease with this ;)

Anyhow, I think that the case "Our master is Mysql 5.7, our slave is Mysql 5.6, and there is a doctrine specific code that will target only 5.7" ;)

If you want to close this, because it "should" work like this, no problem.

[javiereguiluz]

@jdeniau thanks for the info. I agree merging this change because the current behavior is wrong. But I've created doctrine/DoctrineBundle#711 too to see if this can be changed or not. Thanks!

[xabbuh]

Thank you @jdeniau.