Skip to content

Update security.rst #8568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2017
Merged

Update security.rst #8568

merged 2 commits into from
Nov 2, 2017

Conversation

senenh
Copy link
Contributor

@senenh senenh commented Oct 30, 2017

No description provided.

@OskarStark
Copy link
Contributor

IMO it looks correct to like it is:
screenshot 2017-11-01 10 02 02

WDYT @javiereguiluz ?

weaverryan
weaverryan approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we explicitly say at the top there are 3 steps. So this should be numbered :)

@weaverryan
Copy link
Member

Status: Reviewed

@weaverryan
Copy link
Member

Thanks @senenh!

@weaverryan weaverryan merged commit e003213 into symfony:3.3 Nov 2, 2017
weaverryan added a commit that referenced this pull request Nov 2, 2017
@weaverryan
minor #8568 Update security.rst (senenh, weaverryan)
bdab04e 
This PR was merged into the 3.3 branch.

Discussion
----------

Update security.rst

Commits
-------

e003213 more underlining!
701c95e Update security.rst
@xabbuh
Copy link
Member

xabbuh commented Nov 2, 2017

backported to 2.7 in b38ac9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@senenh @OskarStark @weaverryan @xabbuh @carsonbot