[Constraints/Collection] Add missing : and ~ in the yaml code block #8587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Nov 3, 2017
| @@ -223,7 +223,7 @@ you can do the following: | |||
| - Collection: | |||
| fields: | |||
| personal_email: | |||
| - Required | |||
| - Required: | |||
There was a problem hiding this comment.
Is this proposal the right fix?
Shouldn't this:
- Collection:
fields:
personal_email:
- Required:
- NotBlank: ~
- Email: ~be like this instead?
- Collection:
fields:
personal_email:
- Required: ~
- NotBlank: ~
- Email: ~There was a problem hiding this comment.
I did not know about "Required" before (always used NotBlank), but I tried
- Required:
- NotBlank: ~
- Email: ~
And it works, and I based my guess also on the annotation code block
@Assert\Required({@Assert\NotBlank, @Assert\Email})
Which seems to be, for required, a combination of constraints
But according to this:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Constraints/Required.php
Your guess seems correct too, as it can be nested or a side by side constraint
There was a problem hiding this comment.
The nesting is correct here. We do specify the constraints that are required for each collection entry.
|
Thanks @NicolasDievart! |
weaverryan
added a commit
that referenced
this pull request
Nov 5, 2017
…de block (NicolasDievart) This PR was merged into the 2.7 branch. Discussion ---------- [Constraints/Collection] Add missing : and ~ in the yaml code block There were some typos in the yaml code block, some missing : and ~ Commits ------- 2778d33 Add missing : and ~ in the yaml code block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some typos in the yaml code block, some missing : and ~