Skip to content

Update micro_kernel_trait.rst #8676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Update micro_kernel_trait.rst #8676

merged 1 commit into from
Nov 16, 2017

Conversation

StepanMe
Copy link
Contributor

"This method builds and configures..." instead of "This methods builds and configures"

"This method builds and configures..." instead of "This methods builds and configures"
@weaverryan
Copy link
Member

Of course! Thank you Stepan!

@weaverryan weaverryan merged commit 897a571 into symfony:3.3 Nov 16, 2017
weaverryan added a commit that referenced this pull request Nov 16, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

Update micro_kernel_trait.rst

"This method builds and configures..." instead of "This methods builds and configures"

Commits
-------

897a571 Update micro_kernel_trait.rst
@xabbuh
Copy link
Member

xabbuh commented Nov 16, 2017

I have cherry picked this for the 2.8 in f0b833a too.

@weaverryan
Copy link
Member

Ah, thanks. I even thought about that, and forgot it exists in 2.8!

@StepanMe
Copy link
Contributor Author

I don't know why, but some images are not shown in "current" version of docs. In previous versions (3.2) they are OK.
For example, on page http://symfony.com/doc/current/doctrine/associations.html I see alt text of image ("../_images/mapping_relations.png") instead of the image (http://symfony.com/doc/current/_images/mapping_relations.png).

But link http://symfony.com/doc/current/_images/mapping_relations.png has a 301 redirect to http://symfony.com/doc/3.3/_images/mapping_relations.png. Seems it does not work correctly.

The same problem on some other pages of current version of the docs :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants