Added tip to require browser-kit in WebTestCase. #8861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Dec 11, 2017
testing.rst
Outdated
|
|
||
| .. tip:: | ||
|
|
||
| Do not forget to require the ``browser-kit`` component via ``composer require browser-kit``, if you want to use the ``WebTestCase`` class. |
There was a problem hiding this comment.
I would start the section (i.e. right under the "Your First Functional Test" headline) like this:
First, install the BrowserKit component in your project:
.. code-block:: terminal
$ composer require --dev browser-kit
xabbuh
approved these changes
Dec 13, 2017
|
Thank you @Rubinum. |
xabbuh
added a commit
that referenced
this pull request
Dec 22, 2017
…, Tim Jabs) This PR was merged into the 4.0 branch. Discussion ---------- Added tip to require browser-kit in WebTestCase. Hello, I played around with the WebTestCase in Symfony 4+ and I came across that fact, that you have to require the browser-kit component to use the WebTestCase class. For people who don't know the internals of symfony, it can be hard to figure out what to do now, because all they got is this error message: ``` php bin/phpunit tests #!/usr/bin/env php PHPUnit 6.5.3 by Sebastian Bergmann and contributors. Testing tests PHP Fatal error: Class 'Symfony\Component\BrowserKit\Client' not found in /media/tim/996cb512-7026-4e7a-8f4b-f2f38c02939f/tim/PhpstormProjects/symfony4TestRoutes/vendor/symfony/http-kernel/Client.php on line 31 ``` With the new flex system, this could be confusing for some developers, that they have to require additional packages. It think it is good to mention that in the docs. If I missed something here or if you think that the browser-kit should be required by the packages which provides `ẀebTestCase` and it is a WIP thing, then let me know that. Commits ------- 9ae575b Moved tip block to headline. Changed tip description. dcf2265 Changed spelling b266c1b Added tip to require browser-kit in WebTestCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I played around with the WebTestCase in Symfony 4+ and I came across that fact, that you have to require the browser-kit component to use the WebTestCase class.
For people who don't know the internals of symfony, it can be hard to figure out what to do now, because all they got is this error message:
With the new flex system, this could be confusing for some developers, that they have to require additional packages.
It think it is good to mention that in the docs.
If I missed something here or if you think that the browser-kit should be required by the packages which provides
ẀebTestCaseand it is a WIP thing, then let me know that.