Skip to content

Missing link or explanation why no link is provided #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Missing link or explanation why no link is provided #9040

wants to merge 1 commit into from

Conversation

AntoniusGolly
Copy link

The document says

The Symfony Standard Edition comes with a handy task that creates a fully-functional
bundle for you. Of course, creating a bundle by hand is pretty easy as well.

What is that handy task? In the following documentation the manual way is described.

Maybe something like this?
http://symfony.com/doc/current/bundles/SensioGeneratorBundle/commands/generate_bundle.html
This document is not tagged with v4, however it has "current" in its url path.

The document says "The Symfony Standard Edition comes with a handy task that creates a fully-functional
bundle for you. Of course, creating a bundle by hand is pretty easy as well." What is that handy task? In the following documentation the manual way is described.
@Simperfit
Copy link
Contributor

Simperfit commented Jan 12, 2018

You should create an issue for this kind of problem, the better for v4.0 is to use https://github.com/symfony/maker-bundle without any bundle IMHO.

For <4.0 you need to use SensioGeneratorBundle IMHO.

@AntoniusGolly
Copy link
Author

AntoniusGolly commented Jan 13, 2018

The maker-bundle you linked is a proper tool to create controllers or commands, etc. But not to generate a new bundle and register it automatically.

The part of the documentation I refer to is about bundles. The doc mentions an automated way and a manual way, then explains the manual way. Either, if there is no longer a recommended automated way to generate and register a bundle (in ./config/bundles.php) then the docs should exclude the mentioning of

"comes with a handy task that creates a fully-functional bundle for you"

or a section should be linked where it is explained how to do it automatically.

@javiereguiluz
Copy link
Member

@AntoniusGolly thanks for making us aware of this oversight. I'm trying to fix it in #9052.

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jan 13, 2018
javiereguiluz added a commit that referenced this pull request Jan 13, 2018
…(javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Mention the SensioGeneratorBundle in the bundles article

This fixes #9040.

Commits
-------

276109d Mention the SensioGeneratorBundle in the bundles article
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Status: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants