Skip to content

Update built_in_web_server.rst #9091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Update built_in_web_server.rst #9091

merged 2 commits into from
Jan 23, 2018

Conversation

MacDada
Copy link
Contributor

@MacDada MacDada commented Jan 21, 2018

Kernel cannot extend Kernel ;)

Kernel cannot extend Kernel ;)
@xabbuh xabbuh added this to the 4.0 milestone Jan 22, 2018
@xabbuh
Copy link
Member

xabbuh commented Jan 22, 2018

I think we should remove the whole paragraph that is describing how to enable the bundle as this is done automatically for us by Flex.

@javiereguiluz
Copy link
Member

@MacDada your original fix was absolutely correct ... but as @xabbuh said, the real problem is that this article contained some unnecessary steps to install the server, because now we can suppose that Symfony Flex is being used. That's why we made some changes to your pull request. Thanks!

@javiereguiluz javiereguiluz merged commit eefbe7f into symfony:4.0 Jan 23, 2018
javiereguiluz added a commit that referenced this pull request Jan 23, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Update built_in_web_server.rst

Kernel cannot extend Kernel ;)

Commits
-------

eefbe7f Removed some contents unnecessary when using Flex
004526b Update built_in_web_server.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants