Skip to content

Mention the website-skeleton in the getting started guide #9108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #8989.

@weaverryan you said that even if we show website-skeleton, you still want to show how to install each individual dependency. So, we shouldn't change anything from the original contents, right?

@weaverryan
Copy link
Member

Question: when reading the setup doc, does anything else need to be updated (possible language about how small the project is, or something like that? Or a description of what you now have in your project?). These types of changes I think are where we’ve had problems in the past: making a tweak without considering the whole document (I could be wrong in this case - we just need to check!)

setup/flex.rst Outdated
logger mailer form orm-fixtures security translation validator
$ composer require annotations asset orm-pack twig \
logger mailer form security translation validator
$ composer require --dev dotend maker-bundle orm-fixtures profiler
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotenv ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you.

@xabbuh xabbuh added this to the 4.0 milestone Jan 23, 2018
@javiereguiluz
Copy link
Member Author

I've checked this again and the only section which could be a bit weird is https://symfony.com/doc/current/page_creation.html#auto-installing-recipes-with-symfony-flex because it says that if you run composer require annotations you'll see the recipe being installed ... but that it's not entirely true because this was installed when creating the project with website-skeleton. I'm leaving it "as is" because changing this could require to refactor this section and move it somewhere else.

javiereguiluz added a commit that referenced this pull request Jan 26, 2018
… (javiereguiluz)

This PR was squashed before being merged into the 4.0 branch (closes #9108).

Discussion
----------

Mention the website-skeleton in the getting started guide

This fixes #8989.

@weaverryan you said that even if we show `website-skeleton`, you still want to show how to install each individual dependency. So, we shouldn't change anything from the original contents, right?

Commits
-------

5ff66f3 Mention the website-skeleton in the getting started guide
@xabbuh xabbuh closed this Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants