mention phpunit bridge in bundle best practices #9185
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Feb 2, 2018
There was a problem hiding this comment.
@dbu thanks for this! I totally missed that we don't mention that using simple-phpunit in your Travis CI config requires installing something first. To make things more concise, I merged your two notes into a comment exactly at the line where simple-phpunit is used, so readers don't miss it. Thank you!
|
Thanks David. |
javiereguiluz
added a commit
that referenced
this pull request
Feb 3, 2018
…iereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- mention phpunit bridge in bundle best practices i noticed that the bundle best practices don't mention the phpunit bridge. should we go even further and add it to the list of things a bundle should be using? Commits ------- 4854c03 Reword dce07d5 mention phpunit bridge in bundle best practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i noticed that the bundle best practices don't mention the phpunit bridge. should we go even further and add it to the list of things a bundle should be using?