[Serializer] feature: add the context key and add a link to the encoders in serializer to avoid duplication. #9296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
changed the title
dunglas
approved these changes
Feb 19, 2018
Simperfit
changed the title
| @@ -605,23 +605,7 @@ There are several types of normalizers available: | |||
| Encoders | |||
There was a problem hiding this comment.
Considering that we show all the information about Normalizers in this article ... I think the change should be the opposite: delete the serializer/encoders.rst article entirely and move its contents to this Encoders section.
|
Status: Needs Review |
javiereguiluz
added
Status: Reviewed
Serializer
and removed
Status: Needs Review
labels
|
Hamza, thanks for your work here. In addition to documenting missing things, you removed a small doc article, and we always love that! Cheers. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 12, 2018
…to the encoders in serializer to avoid duplication. (Simperfit) This PR was merged into the master branch. Discussion ---------- [Serializer] feature: add the context key and add a link to the encoders in serializer to avoid duplication. Fixes #9384 and #9383. Commits ------- e6d3f77 feature: add the context key documentation and remove encoders documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9384 and #9383.