Skip to content

Update requirements.rst #9335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Update requirements.rst #9335

merged 1 commit into from
Feb 25, 2018

Conversation

marko89kv
Copy link
Contributor

the package name wasn't complete, it should be "symfony/requirements-checker"

the package name wasn't complete, it should be "symfony/requirements-checker"
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically is not needed for most users (because in the docs we assume that the reader is using Symfony Flex) ... but this requirements-checker package is a bit special and lots of people may need it to check if their system is ready for Symfony ... so let's merge it. Thanks!

@javiereguiluz javiereguiluz merged commit 51ea313 into symfony:4.0 Feb 25, 2018
javiereguiluz added a commit that referenced this pull request Feb 25, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Update requirements.rst

the package name wasn't complete, it should be "symfony/requirements-checker"

Commits
-------

51ea313 Update requirements.rst
@marko89kv marko89kv deleted the patch-1 branch February 26, 2018 06:46
@marko89kv
Copy link
Contributor Author

thanks! @javiereguiluz
I'll make sure I get something better next time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants