Fix FQCN in PHP example for expression language #9420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This is indeed correct (thanks to the many engines that parse this string and remove one backslash). I think XML would need just two backslashes (as the XML engine, unlike YAML and PHP, doesn't remove backslashes from text). Feel free to push another commit to this branch to fix that, or we'll manage during the merge. status: reviewed |
javiereguiluz
added a commit
that referenced
this pull request
Mar 11, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9422). Discussion ---------- Fix FQCN in XML example for expression language <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> As discussed in #9420 Commits ------- 29c981c Fix FQCN in XML example for expression language
|
Thanks for this one too. Merged it on 3.4 branch. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 11, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9420). Discussion ---------- Fix FQCN in PHP example for expression language <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> I was following the example and got an error `You have requested a non-existent service \"AppMailMailerConfiguration\"`. I debugged it and I think it’s not an code issue but just the documentation. The YAML version also uses 4 `\`. Maybe we need to fix the XML version as well but I wasn’t sure and didn’t have time to test it. Commits ------- a268135 Fix FQCN in PHP example for expression language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following the example and got an error
You have requested a non-existent service \"AppMailMailerConfiguration\". I debugged it and I think it’s not an code issue but just the documentation. The YAML version also uses 4\. Maybe we need to fix the XML version as well but I wasn’t sure and didn’t have time to test it.