Skip to content

change targetDirectory to targetDir #9449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thamerbelfkihthamer
Copy link

the argument name passed for the FileUploader service class is not the same inside the service.yml file

the argument name passed for the FileUploader service  class is not the same inside the service.yml file
@javiereguiluz
Copy link
Member

@thamerbelfkihthamer thanks for your contribution! Although your pull request is technically correct, I'm afraid the problem is another one. We recently changed some variable names. One of them was targetDir renamed to targetDirectory. So, the problem we must fix is the other way around: find the targetDir leftovers and rename them to targetDirectory. We did that in #9464, so we're closing this then. I'm sorry ... but I hope to see more contributions from you in the future.

javiereguiluz added a commit that referenced this pull request Mar 21, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Fixed some variable names

Fixes #9449 differently.

Commits
-------

5510f59 Fixed some variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants