Skip to content

Form doc fix #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Form doc fix #95

wants to merge 1 commit into from

Conversation

beryllium
Copy link

  • Adjusted the namespace and import usages to be accurate and correct
  • Removed references to EmailField, which does not exist.
  • Added a reference to "mailer" for when ContactRequest is instantiated, because it is required for the constructor.
  • Added a name to the form::create() method, because it is required for form submission
  • Modified template to put form in a block, as required by twig parsing

@weaverryan
Copy link
Member

Merged - thanks!

xabbuh pushed a commit that referenced this pull request Jul 28, 2016
@javiereguiluz
minor #97 Rewrote the Console articles (WouterJ, javiereguiluz)
d02479e 
This PR was merged into the 2.7 branch.

Discussion
----------

Rewrote the Console articles

This just tweaks a bit the great work made by Wouter in #95.

Commits
-------

e24270c Rewords
270ebc7 Tweaked the Console article
fe05d1a Fix build
2d21a17 Remove all other duplication from components article
cd142c7 Move Testing commands to the guide
d3b9f02 Move Console helper links to guide
53f1dd1 Move `Calling other commands` to a guide article
038a045 Move Command Lifecycle to guide
cbca1c0 Rewrote Console Commands introduction
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beryllium @weaverryan