Replace jQuery example with plain JavaScript #9528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Mar 31, 2018
There was a problem hiding this comment.
I like this a lot! Thanks for this improvement. I'd like to make a minot suggestion though. What if we turn this into a note and reword the link to MDN docs to make it more concise? Like this:
.. note::
When `accessing data attributes from JavaScript`_, the attribute names are
converted from dash-style to camelCase. For example, ``data-is-authenticated``
becomes ``isAuthenticated`` and ``data-number-of-reviews`` becomes
``numberOfReviews``.
.. _`accessing data attributes from JavaScript`: https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes
|
@javiereguiluz I agree, your suggestion makes it look better and reads more clearly. I have updated this PR. |
|
Thanks a lot for this improvement! And congrats on your first Symfony Docs contribution |
javiereguiluz
added a commit
that referenced
this pull request
Apr 3, 2018
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #9528). Discussion ---------- Replace jQuery example with plain JavaScript The data attributes example relies unnecessarily on jQuery and is potentially more confusing because it masks how attributes actually work in JavaScript and it's another level of abstraction to deal with. It is a better idea to promote web standards here because people tend to copy what they see, so let's steer them in a future-friendly direction. Commits ------- 0dfcbd8 Replace jQuery example with plain JavaScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data attributes example relies unnecessarily on jQuery and is potentially more confusing because it masks how attributes actually work in JavaScript and it's another level of abstraction to deal with. It is a better idea to promote web standards here because people tend to copy what they see, so let's steer them in a future-friendly direction.