Skip to content

Fix "DateTimeInterface" URL #9534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Fix "DateTimeInterface" URL #9534

merged 2 commits into from
Apr 4, 2018

Conversation

liviubalan
Copy link
Contributor

serializer.rst Outdated
@@ -99,7 +99,7 @@ As well as the following normalizers:
* :class:`Symfony\\Component\\Serializer\\Normalizer\\ObjectNormalizer` to
handle typical data objects
* :class:`Symfony\\Component\\Serializer\\Normalizer\\DateTimeNormalizer` for
objects implementing the :class:`DateTimeInterface` interface
objects implementing the `DateTimeInterface`_ interface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use :phpclass: instead

@liviubalan
Copy link
Contributor Author

Done! Thanks for the info!

@xabbuh xabbuh added this to the 3.4 milestone Apr 3, 2018
@javiereguiluz
Copy link
Member

Thanks for this and all the other changes related to PHP classes!

@javiereguiluz javiereguiluz merged commit b99957b into symfony:3.4 Apr 4, 2018
javiereguiluz added a commit that referenced this pull request Apr 4, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

Fix "DateTimeInterface" URL

Change generated URL "http://api.symfony.com/3.4/DateTimeInterface.html" to "http://php.net/manual/en/class.datetimeinterface.php"

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

b99957b Changes after code review
1ebd63d Fix "DateTimeInterface" URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants