Skip to content

Update security_checker.rst #9544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update security_checker.rst #9544

wants to merge 1 commit into from

Conversation

benoitdelaunay
Copy link

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Apr 5, 2018

Thank you for this PR @benoitdelaunay. Did you experience any issue with the old example? security-checker is a defined alias for the sensiolabs/security-checker package. So this change shouldn't be necessary.

@javiereguiluz javiereguiluz mentioned this pull request Apr 18, 2018
Merged
@javiereguiluz
Copy link
Member

@benoitdelaunay thanks for this contribution. In Symfony Docs we assume that the reader is using Symfony Flex, so aliases like composer require security-checker work without adding the sensiolabs/ package vendor.

However, I think you are right that this command is a bit special because it can be used with any Symfony version and even in any PHP app (where Flex is not available). So I've opened #9618 to mention that. Let's close this one for now.

We're sorry that your contribution wasn't merged this time ... but we hope to receive more contributions from you in the future. Cheers!

javiereguiluz added a commit that referenced this pull request Apr 19, 2018
@javiereguiluz
minor #9618 Added a note about using the security checker independent…
b946e78 
…ly (javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Added a note about using the security checker independently

Related to #9544.

Commits
-------

45e3ffa Added a note about using the security checker independently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benoitdelaunay @xabbuh @javiereguiluz @carsonbot