Fix typo in method setETag. Correct method name is setEtag #9546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice catch! Thanks for fixing it. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 5, 2018
…g (Artem Henvald) This PR was merged into the 2.7 branch. Discussion ---------- Fix typo in method setETag. Correct method name is setEtag Just small typo fixed. I have copy pasted code from docs and then my code sniffer notified about mismatched method name. Here is a link to API https://api.symfony.com/4.0/Symfony/Component/HttpFoundation/Response.html#method_setEtag Commits ------- 6a2a877 Fix typo in method setETag. Correct method name is setEtag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small typo fixed. I have copy pasted code from docs and then my code sniffer notified about mismatched method name.
Here is a link to API https://api.symfony.com/4.0/Symfony/Component/HttpFoundation/Response.html#method_setEtag