Change IntegerType::scale default value to 0 #9549
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will also affect the |
|
Indeed. I grepped around to see if that file was included and I failed to see that it was used by |
As pointed out in the comments of symfony/pull/9549, the scale.rst.inc file is included twice: once in integer.rst (the goal of the PR) and once in number.rst. number.rst should not see this edit as its scale parameter is not ignored. Hence, the inclusion was removed from integer.rst and the edit was made. number.rst is now identical to base ref.
|
Done. Note that the Would that be interesting to change in this PR? |
|
dupe of #9542 |
|
Indeed, thanks. |
BenoitDuffez
deleted the
BenoitDuffez-patch-fix-reference-forms-types-integer-scale-zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is 0 and can't be changed
see symfony/symfony#26795
see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php#L35: the PHPDoc says it's unused, but the doc doesn't.