Remove faulty PHP code blocks #9554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_instanceof` and `_defaults` APIs have not equivalent for the low-level Definition API, as they are resource-scoped features and the low-level API does not have any concept of resource doing the definition.
xabbuh
approved these changes
Apr 4, 2018
|
Thanks Christophe. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 5, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Remove faulty PHP code blocks The `_instanceof` and `_defaults` APIs have not equivalent for the low-level Definition API, as they are resource-scoped features and the low-level API does not have any concept of resource doing the definition. `registerForAutoconfiguration` is totally unrelated to `_instanceof`. It is the partner of the ` autoconfigure` API. A valid replacement could be to use the new PHP DSL (which has equivalent features), but I don't think it is used anywhere in the DI documentation yet. And using it would require a policy about how to distinguish code blocks using the PHP DSL in a config file, and code blocks using the lower-level PHP API. So I kept this out of this PR, by only removing wrong doc. Commits ------- cbcbb43 Remove faulty PHP code blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_instanceofand_defaultsAPIs have not equivalent for the low-level Definition API, as they are resource-scoped features and the low-level API does not have any concept of resource doing the definition.registerForAutoconfigurationis totally unrelated to_instanceof. It is the partner of theautoconfigureAPI.A valid replacement could be to use the new PHP DSL (which has equivalent features), but I don't think it is used anywhere in the DI documentation yet. And using it would require a policy about how to distinguish code blocks using the PHP DSL in a config file, and code blocks using the lower-level PHP API. So I kept this out of this PR, by only removing wrong doc.