[Encore] Encore.configureUrlLoader() documentation #9606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Apr 18, 2018
There was a problem hiding this comment.
@Lyrkan thanks a lot for this contribution! I love it (and I love the described feature too!! I needed a while ago and I really missed it!).
As you can see, I've made some rewords ... but they are only made to make the article more consistent with the style used in other parts of the Symfony Docs. I also update the article title to make it more SEO-friendly: Inlining files in CSS with Webpack URL Loader
Thanks again for your work ... and congrats on your first Symfony Docs contribution!
javiereguiluz
added
Status: Reviewed
Webpack Encore
and removed
Status: Needs Review
labels
|
It's merged now! Thank you. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 19, 2018
…n, javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Encore] Encore.configureUrlLoader() documentation This PR adds the documentation for the `Encore.configureUrlLoader()` method (symfony/webpack-encore#296). Not sure if it should be more detailed since the other options of the URL loader are typically not needed... Commits ------- 5c87901 Use the default article title 4d8700f Reword 6820867 Encore.configureUrlLoader() documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the documentation for the
Encore.configureUrlLoader()method (symfony/webpack-encore#296).Not sure if it should be more detailed since the other options of the URL loader are typically not needed...