Skip to content

MessageBus::handle does not exit. It is called MessageBus::dispatch #9624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2018
Merged

MessageBus::handle does not exit. It is called MessageBus::dispatch #9624

merged 1 commit into from
Apr 19, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Apr 19, 2018

FYI @sroze

sroze
sroze approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@sroze sroze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oupsss, good catch.

@javiereguiluz
Copy link
Member

Good catch, thanks Tobias.

@javiereguiluz javiereguiluz merged commit d30bdd5 into symfony:master Apr 19, 2018
javiereguiluz added a commit that referenced this pull request Apr 19, 2018
@javiereguiluz
minor #9624 MessageBus::handle does not exit. It is called MessageBus…
001f5dd 
…::dispatch (Nyholm)

This PR was merged into the master branch.

Discussion
----------

MessageBus::handle does not exit. It is called MessageBus::dispatch

FYI @sroze

Commits
-------

d30bdd5 MessageBus::handle does not exit. It is called MessageBus::dispatch
@Nyholm Nyholm deleted the patch-messenger branch April 19, 2018 13:50
@Nyholm
Copy link
Member Author

Nyholm commented Apr 19, 2018

Thank you for the reviews and for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sroze sroze sroze approved these changes

Assignees
No one assigned
Labels
bug Messenger Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @javiereguiluz @sroze @carsonbot