Incompatible ts-loader version #9690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ts-loader major version must map to the webpack major version: TypeStrong/ts-loader#748
javiereguiluz
added
bug
Status: Reviewed
Webpack Encore
and removed
Status: Needs Review
labels
|
Nice catch! We merged it on 3.4 branch. Congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Apr 27, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9690). Discussion ---------- Incompatible ts-loader version The ts-loader major version must map to the webpack major version: TypeStrong/ts-loader#748 Since symfony/encore depends on webpack 3, installing latest will produce the error above. Commits ------- 8f2d2f1 Incompatible ts-loader version
|
@javiereguiluz This change was never merged, the docs still reference the un-constrained ts-loader installation. |
|
Reopening so I can investigate what happened. Thanks @ldawkes! |
|
I couldn't fix this error in any way, so I did this change myself again and committed directly to supported branches. The change is now in the repo (see https://github.com/symfony/symfony-docs/blob/master/frontend/encore/typescript.rst) and it will be on symfony.com after the next doc generation. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ts-loader major version must map to the webpack major version:
TypeStrong/ts-loader#748
Since symfony/encore depends on webpack 3, installing latest will produce the error above.