Skip to content

Use '[]' notation, add missing "()" update class name #9850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use '[]' notation, add missing "()" update class name #9850

wants to merge 1 commit into from

Conversation

jmontoyaa
Copy link
Contributor

No description provided.

@javiereguiluz javiereguiluz added this to the 3.4 milestone May 29, 2018
@javiereguiluz
Copy link
Member

@jmontoyaa thanks for this improvement. We merged it on the 3.4 branch and we'll merge it automatically on the other branches. By the way, we reverted the changes in the array notation. Symfony Docs follows the practices of Symfony code, so that's mean using long array notation. Finally, congrats on your first Symfony Docs contribution!

javiereguiluz added a commit that referenced this pull request May 29, 2018
@javiereguiluz
minor #9850 Use '[]' notation, add missing "()" update class name (jm…
b454cd0 
…ontoyaa)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #9850).

Discussion
----------

Use '[]' notation, add missing "()" update class name

Commits
-------

a0a2dce Use '[]' notation, add missing "()" update class name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jmontoyaa @javiereguiluz @carsonbot