Skip to content

Fixed minor typo #9957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed minor typo #9957

wants to merge 1 commit into from

Conversation

axzx
Copy link
Contributor

@axzx axzx commented Jun 23, 2018

No description provided.

@apfelbox
Copy link
Contributor

I actually think, that the previous version is correct. In the end, the top-level fingers_crossed handler is wrapping swift, so it is indeed a "mail" handler.

@HeahDude
Copy link
Contributor

Yes but the convention is to have a fingers_crossed called main https://github.com/symfony/symfony-standard/blob/3.4/app/config/config_prod.yml#L12, so I do think it is typo too.

HeahDude
HeahDude approved these changes Jun 23, 2018
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@apfelbox
Copy link
Contributor

@HeahDude ah, didn't know that. Nevermind then 😉

@javiereguiluz
Copy link
Member

Thank you @axzx.

javiereguiluz added a commit that referenced this pull request Jun 25, 2018
@javiereguiluz
minor #9957 Fixed minor typo (axzx)
63ab8ce 
This PR was submitted for the 4.1 branch but it was merged into the 2.8 branch instead (closes #9957).

Discussion
----------

Fixed minor typo

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

b464b31 Fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@axzx @apfelbox @HeahDude @javiereguiluz @carsonbot