This repository was archived by the owner on Nov 27, 2020. It is now read-only.
explicitly declare supported Twig versions #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this needs to be done in 2.7 as well. |
Not being explicit which Twig versions the application supports mean that users will get new major Twig releases when they become stable and composer update is run. This can lead to undesired effects when the new ajor release is breaking backwards compatibility.
|
Okay, I changed the target branch. |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2017
This PR was merged into the 2.7 branch. Discussion ---------- explicitly declare supported Twig versions Not being explicit which Twig versions the application supports mean that users will get new major Twig releases when they become stable and composer update is run. This can lead to undesired effects when the new ajor release is breaking backwards compatibility. Commits ------- a927eb5 explicitly declare supported Twig versions
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Feb 17, 2017
…harsky-bw) This PR was squashed before being merged into the master branch (closes #477). Discussion ---------- Update to Symfony 3.2.4 and start supporting Twig 2 Symfony SE already do it: symfony/symfony-standard#1045 - Updating symfony/symfony (v3.2.3 => v3.2.4) Downloading: 100% - Installing ircmaxell/password-compat (v1.0.4) Loading from cache - Installing symfony/polyfill-php55 (v1.3.0) Loading from cache - Updating sensio/framework-extra-bundle (v3.0.21 => v3.0.22) Downloading: 100% - Updating white-october/pagerfanta-bundle (v1.0.7 => v1.0.8) Downloading: 100% - Updating friendsofphp/php-cs-fixer (v2.0.0 => v2.1.0) Downloading: 100% - Updating symfony/phpunit-bridge (v3.2.3 => v3.2.4) Loading from cache - Updating doctrine/dbal (v2.5.11 => v2.5.12) Loading from cache - Updating swiftmailer/swiftmailer (v5.4.5 => v5.4.6) Downloading: 100% Commits ------- b6e7c78 Update to Symfony 3.2.4 and start supporting Twig 2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not being explicit which Twig versions the application supports mean
that users will get new major Twig releases when they become stable and
composer update is run. This can lead to undesired effects when the new
ajor release is breaking backwards compatibility.