This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Use getRootDir() rather than assuming __DIR__ #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense I guess 👍 |
|
what's the holdup on this one? any reason not to have it? |
|
Thank you @thewilkybarkid. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Use getRootDir() rather than assuming __DIR__ In the event that `getRootDir()` in `AppKernel` is overridden (eg the file is moved elsewhere but the config etc stays put), the `registerContainerConfiguration` would also have to be changed. Commits ------- 36ab0c1 Use getRootDir() rather than assuming __DIR__
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that
getRootDir()inAppKernelis overridden (eg the file is moved elsewhere but the config etc stays put), theregisterContainerConfigurationwould also have to be changed.