Move the placeholder for assets version in config.yml #891
Conversation
Uncommenting ’#assets_version: SomeVersionScheme’ will cause an exception in Symfony 2.7+ The parameter was moved to framework -> asserts.
| @@ -32,6 +31,7 @@ framework: | |||
| fragments: ~ | |||
| http_method_override: true | |||
| assets: ~ | |||
| #version: SomeVersionScheme | |||
There was a problem hiding this comment.
If the user only uncomment this line, it won't work as he also needs to remove the ~ above. Instead, I would just remove the whole comment above (assets_version)
There was a problem hiding this comment.
This makes sense, but hides the fact that the assets can (and should) be versioned. Not sure what is better / worse.
|
Docs need updating too as they still refer to the old Perhaps, mentioning assets version bundle there will be useful too. |
|
👍 Status: Reviewed |
|
Should be merged in 2.7 as that is where this config has been deprecated. But this will conflict currently as |
|
👍 |
|
Thank you @kachkaev. |
…hkaev) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #891). Discussion ---------- Move the placeholder for assets version in config.yml Uncommenting ’#assets_version: SomeVersionScheme’ will cause an exception in Symfony 2.7+ The parameter was moved to framework -> asserts. Commits ------- d1cafee Move the placeholder for assets version in config.yml
Uncommenting ’#assets_version: SomeVersionScheme’ will cause an exception in Symfony 2.7+ The parameter was moved to framework -> asserts.